m/grafX2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

realpath.c: passing NULL is POSIX-2008 compliant

Browse Source 
also default MAX_PATH to 4096 which is more realistic than 32768
(4096 is the value in linux)
This commit is contained in:
Thomas Bernard 2018-12-10 13:34:02 +01:00
parent ec4ad8adb2
commit c9c4891b46
No known key found for this signature in database
GPG Key ID: 0FF11B67A5C0863C
1 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/realpath.c
View File

@ -25,9 +25,9 @@
// the path. So this implementation is limited, it's really better to
// use realpath() if your platform has it.
#if defined(__GP2X__) || defined(__WIZ__) || defined(__CAANOO__) || defined(__amigaos__)
#if !defined(PATH_MAX)
// This is a random default value ...
#define PATH_MAX 32768
#define PATH_MAX 4096
#endif
static char *sep(char *path)
@ -123,18 +123,22 @@
return _fullpath(resolved_path,_path,260);
}
#else
#include <limits.h>
// Use the stdlib function.
char *Realpath(const char *_path, char *resolved_path)
{
// While linux version of realpath handles the resolved_path being a
// null pointer, this is not the case for other platforms (Haiku), nor
// specified by the open group in POSIX. So, be safe and allocate
// ourselves.
if(resolved_path==NULL) // if we called realpath with null as a 2nd arg
resolved_path = (char*) malloc( PATH_MAX );
return realpath(_path, resolved_path);
/// POSIX 2004 states :
/// If resolved_name is a null pointer, the behavior of realpath()
/// is implementation-defined.
///
/// but POSIX 2008 :
/// If resolved_name is a null pointer, the generated pathname shall
/// be stored as a null-terminated string in a buffer allocated as if
/// by a call to malloc().
///
/// So we assume all platforms now support passing NULL.
/// If you find a platform where this is not the case,
/// please add a new implementation with #ifdef's.
return realpath(_path, resolved_path);
}
#endif