commit 3fa8c98c17b01246c3d39acbeedf4b3db4de6654
changed line ending for doc/quickstart.rtf
My git then went havoc ;) I have done some investigations
and it looks like the good practice is to use the local
line endings for RTF files and just have
*.rtf diff=astextplain
in the .gitattributes file
Gradient ellipse (corners) tool had no clipping code, and would draw off the bottom or right edge of the image.
Clipping code has been added, similar to other tools.
This gives a much clearer overview of the licensing.
It also shows there are some problems:
- Some files are under GPLv3 only
- Some files have no known license at all.
If a filename passed from the command line arguments is ever longer than
the current working directory (and it usually is longer), strcpy will
overrun the working directory buffer. This usually doesn't cause a crash
right away, but it caused weird bugs for me, like an assertion failure
in free() when trying to free the buffer later:
free(): invalid next size (fast)
Valgrind helped me track down the cause:
$ valgrind bin/grafx2-sdl ~/Projects/kind-of-longish-directory-name/file.gif
...
==116375== Invalid write of size 1
==116375== at 0x483DDE6: strcpy (vg_replace_strmem.c:511)
==116375== by 0x1265B2: Init_program (main.c:1104)
==116375== by 0x12704F: main (main.c:1536)
==116375== Address 0x5534a81 is 21 bytes after a block of size 28 alloc'd
==116375== at 0x483CD7B: realloc (vg_replace_malloc.c:834)
==116375== by 0x4E70F3F: getcwd (in /usr/lib/libc-2.32.so)
==116375== by 0x17277E: Get_current_directory (io.c:1096)
==116375== by 0x125B02: Init_program (main.c:655)
==116375== by 0x12704F: main (main.c:1536)
